zhengruifeng commented on PR #58253:
URL: https://github.com/apache/spark/pull/58253#issuecomment-5711066751
I reviewed the latest revision. The implementation and focused tests look
sound, but the public protobuf option documentation should be updated to
describe the new present-wrapper default behavior and its interaction with
emit.default.values.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5446087469","thread_id":"conversation:5446087469","verdict_sha256":"1903df64664967c15b9bc085632ef3ac673958a3a1041ec40bfe05a55711a42d"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
