cloud-fan commented on code in PR #58408:
URL: https://github.com/apache/spark/pull/58408#discussion_r4035598277
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##########
@@ -2404,7 +2412,10 @@ case class FormatString(children: Expression*) extends
Expression with ImplicitC
val numArgLists = argListGen.length
val argListCode = argListGen.zipWithIndex.map { case(v, index) =>
val value =
- if (CodeGenerator.boxedType(v._1) != CodeGenerator.javaType(v._1)) {
+ if (CodeGenerator.javaClass(v._1) == classOf[Decimal]) {
Review Comment:
Confirmed: the runtime-aware generated branch now converts Decimal values
carried by ObjectType(Object), and the new cases cover Decimal, String, and
null inputs in both evaluation modes.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:3996963525","thread_id":"inline:3996963525","verdict_sha256":"779c400d1fa3c7c4680adaac729d6e76173d492c09385c18a51e50c60804867a"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
