dongjoon-hyun commented on PR #841: URL: https://github.com/apache/spark-kubernetes-operator/pull/841#issuecomment-5713934975
Thank you for the detailed review, @peter-toth . I addressed the comments. 1. Worker default: I took the first option. The operator now logs a warning when a worker has neither `SPARK_WORKER_CORES` and `SPARK_WORKER_MEMORY` nor CPU and memory limits. I also fixed the PR description so that the worker `1` CPU is described as a minimum chosen by the operator, not as a Spark default. 2. Overhead: I applied your suggestion. The overhead is now applied to the daemon heap only, and `SPARK_WORKER_MEMORY` is added as it is. 3. `getEnv`: I applied your Javadoc suggestion and widened the matching bullet in the PR description. 4. Writing `SPARK_WORKER_CORES` and `SPARK_WORKER_MEMORY` from the worker container resources is a good idea. Since it changes the applied `StatefulSet` and touches `spark-submission-worker`, let me handle it in a separate JIRA issue as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
