zhengruifeng commented on code in PR #58729: URL: https://github.com/apache/spark/pull/58729#discussion_r4036722918
########## python/pyspark/sql/eval_handlers/_arrow.py: ########## @@ -0,0 +1,72 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Handlers for the Arrow-native UDF eval types (the UDF exchanges ``pa.Array`` / +``pa.RecordBatch`` values directly, without a pandas conversion).""" + +from collections.abc import Iterator +from typing import TYPE_CHECKING, Any + +from pyspark.sql.conversion import ArrowBatchTransformer +from pyspark.sql.eval_handlers._base import BatchEvalTypeHandler +from pyspark.sql.eval_handlers.verification import verify_scalar_result +from pyspark.sql.pandas.types import to_arrow_schema +from pyspark.sql.types import StructField, StructType +from pyspark.util import PythonEvalType + +if TYPE_CHECKING: + import pyarrow as pa + + from pyspark.worker_util import EvalConf, RunnerConf + + +class ArrowScalarUDFHandler(BatchEvalTypeHandler["pa.RecordBatch"]): Review Comment: nit: we have 'PythonUDFRunner' in the jvm side, and this class just provide a `run` method, not a 'handle'-like one, so shall we rename it `ArrowScalarUDFRunner`? otherwise LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
