cloud-fan commented on PR #58844:
URL: https://github.com/apache/spark/pull/58844#issuecomment-5717997189
I checked the current patch and the related code paths. The queue is used
only through append, next, hasNext, and shouldStop, and the drained large-batch
buffer is now replaced before the next refill. This looks good to me.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:5698558507","thread_id":"conversation:5698558507","verdict_sha256":"400ee956c6fa14fe57dc8ade0bb19915fcf6005b28c8197f756689311756c3b5"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
