Spenserrrr commented on code in PR #58795: URL: https://github.com/apache/spark/pull/58795#discussion_r4040505111
########## python/benchmarks/bench_arrow_to_pandas.py: ########## @@ -24,9 +24,9 @@ count, so ``n_cols`` is swept alongside ``n_rows``: wide batches and small batches are the shapes where that fixed cost dominates. -``ArrowToPandasConversion.convert`` routes each column by type. ``long`` and +``ArrowToPandasConversion._convert_column`` routes each column by type. ``long`` and Review Comment: Good point. I have revised the helper names to `_convert_array`, `_convert_array_legacy`, and `_convert_array_numpy` to reflect that they convert PyArrow arrays, and updated the related callers and references. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
