Richard-Durkee commented on PR #56130: URL: https://github.com/apache/spark/pull/56130#issuecomment-5724039896
> **0 blocking, 1 non-blocking, 0 nits.** > Clean implementation; one minor test coverage gap for the custom `lineSep` error path. > > ### Correctness (1) > - `UnivocityParser.scala:669`: no test covers the `case Some(sep)` stripping branch in `parseLine` when reached via `parseIterator` with a custom `lineSep` — see inline > > <!-- ai-code-review --> Addressed. Would you mind taking another look? Thanks for your patience, forgot to follow up on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
