hemanthboyina commented on code in PR #58666:
URL: https://github.com/apache/spark/pull/58666#discussion_r4048923155
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala:
##########
@@ -602,11 +604,23 @@ object DataSourceV2Relation {
val catalystColStat = ColumnStat(distinct, min, max, nullCount,
avgLen, maxLen, histogram)
- output.foreach(attribute => {
- if (attribute.name.equals(key.describe())) {
- colStats = colStats :+ (attribute -> catalystColStat)
+ // Catalyst statistics are keyed by top-level Attribute, so only
single-part references
+ // can be matched to an output column.
+ val fieldNames = key.fieldNames
+ if (fieldNames.length == 1) {
+ val fieldName = fieldNames.head
+ val matches = output.filter(attribute => resolver(attribute.name,
fieldName))
Review Comment:
Good point, done. Switched to
AttributeSeq.fromNormalOutput(output).getCandidatesForResolution(...) and
recover the original attribute by exprId, so s/ſ and similar case-folding pairs
bucket the same way the analyzer does and we don't attach a stat Spark wouldn't
resolve. Added an s/ſ regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
