dongjoon-hyun commented on code in PR #850:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/850#discussion_r4057504593
##########
spark-operator/src/main/java/org/apache/spark/k8s/operator/kueue/KueueWorkloadUtils.java:
##########
@@ -127,6 +137,97 @@ public static AdmissionResult requestAdmission(
return AdmissionResult.PENDING;
}
+ /**
+ * Resolves the node selector and tolerations of the ResourceFlavors which
Kueue assigned to each
+ * pod set of the admitted Workload, in the same way as Kueue built-in
integrations. The flavors
Review Comment:
Fair enough, the javadoc now scopes the claim in `7f47672`:
```java
* Resolves the node selector and tolerations of the ResourceFlavors which
Kueue assigned to each
* pod set of the admitted Workload, like Kueue's `podset.FromAssignment`.
The Topology Aware
* Scheduling gate and annotation are not handled. ...
```
Thank you also for the `topologyUngater` detail — the fact that it copies
the assigned domain node labels into `pod.Spec.NodeSelector` when it removes
the gate is the part I had missed, and it raises the stakes of the follow-up
from early scheduling to wrong placement. I will carry that into the PR which
wires these flavors into the pods, together with the `topologyName` field and
the loud rejection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
