stefankandic commented on PR #58779: URL: https://github.com/apache/spark/pull/58779#issuecomment-5763166481
@uros-b 1. I don't think the view test is needed. `NullIfResult` creates the null literal after analysis from the final `value.dataType`, so the earlier stale-collation state is no longer possible. 2. Good catch. I replaced the obsolete `typednullliteral` explain check with `nullifresult`. 3. I am keeping `branchGroups = Nil`. The value branch is not always reached, and the proposed singleton group would fail `EquivalentExpressions`' `exprs.length > 1` assertion. 4. The growth test intentionally checks tree size. Nested `nullif` evaluation is already covered in `ColumnExpressionSuite` and `WholeStageCodegenSuite`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
