dongjoon-hyun commented on PR #860: URL: https://github.com/apache/spark-kubernetes-operator/pull/860#issuecomment-5766818243
Thanks for the review, @viirya. All five points were correct; `f6e5936` addresses them. The two classification fixes are answered inline. **Documentation scope.** Updated the Javadoc and the `description` of `API_SECONDARY_RESOURCE_CREATE_MAX_ATTEMPTS`, and regenerated `docs/config_properties.md`. The text no longer claims that retryable errors without a `Retry-After` hint are retried immediately: an unanswered request carries no response status, so it can never supply that hint and is now backed off, which the description says explicitly. **SparkCluster.** You are right — `ClusterInitStep` creates master and worker resources through `serverSideApply()` and never calls `getOrCreateSecondaryResource()`, so the create path is unaffected for them. A `SparkCluster` benefits only through its status updates and its Kueue admission requests. The user-facing paragraph now says so, and also states that retries stay bounded by this configuration (3 by default), so exhausting them still ends in `SchedulingFailure`. **Caller coverage.** Added tests that drive a code `-1` failure through the callers whose events and requeue interval this classification controls: | Test | Covers | | --- | --- | | `StatusRecorderTest.publishesNoEventWhenTheRequestGoesUnanswered` | an unanswered status patch publishes no `StatusUpdateFailed` event | | `StatusRecorderTest.publishesAnEventWhenTheRequestIsRejectedBeforeItIsSent` | a client-side rejection still publishes one | | `AppInitStepTest.kueueUnansweredRequestPublishesNoEvent` | an unanswered admission request requeues at the short interval with no event | | `AppInitStepTest.kueueClientSideRejectionPublishesAnEvent` | a client-side rejection requeues at the default interval with an event | The status-recorder test points the client at a closed port so the failure is a real unanswered request rather than a hand-built exception. PTAL when you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
