Yicong-Huang commented on code in PR #58903:
URL: https://github.com/apache/spark/pull/58903#discussion_r4067139260
##########
python/pyspark/sql/conversion.py:
##########
@@ -180,6 +180,115 @@ def select_columns(cls, batch: "pa.RecordBatch",
column_indices: list[int]) -> "
[batch.schema.names[i] for i in column_indices],
)
+ @staticmethod
+ def concat_batches(batches: Sequence["pa.RecordBatch"]) ->
"pa.RecordBatch":
Review Comment:
yeah `Iterable` won't support `len()`, but I am thinking changing the
implementation so that it first materializes the iterable and then measure the
len() on it. just wonder if we can make the materialization from callsite into
here. again, just a question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
