dongjoon-hyun commented on PR #861: URL: https://github.com/apache/spark-kubernetes-operator/pull/861#issuecomment-5778835951
Thanks @peter-toth. Finding 4 fixed in 950fd4a, taking your suggestion as written. You were right that it was a fifth site rather than one of the four I counted, and right about the direction of the error. The repo's own configuration is the counterexample, as you say: the E2E sets `suspendHoldRequeueIntervalSeconds=10` with `minIntervalSeconds=15`, which the row declared illegal even though the resulting 20 second period sits against a 3600 second TTL, so the row forbade a setting this PR itself relies on rather than merely being conservative. Dropping the clause rather than restating the corrected bound, per your suggestion: the row already links to `#event-frequency`, and that restatement is what drifted in the first place. `grep` for the superseded framing now comes back empty, and the corrected bound is stated in six places — the `Event frequency` section, both option descriptions and the two generated `config_properties.md` rows. `gradle build -x test` is green, `validateConfPropsDocUpToDate` included. Docs-only change, so no test run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
