zhangxinyao88 commented on code in PR #58556:
URL: https://github.com/apache/spark/pull/58556#discussion_r4073266165
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestHelper.scala:
##########
@@ -474,7 +474,7 @@ trait SQLQueryTestHelper extends SQLConfHelper with Logging
{
protected def getSparkSettings(comments: Array[String]): Array[(String,
String)] = {
val settingLines = comments.filter(_.startsWith("--SET
")).map(_.substring(6))
- settingLines.flatMap(_.split(",").map { kv =>
+ settingLines.flatMap(_.split(",(?=[\\w.]+=)").map { kv =>
Review Comment:
> this won't match `--SET some.conf.val = 1` while the previous behavior did
(note spaces around '=') is this intended?
You're right. The single-setting form already worked, but multiple settings
with spaces around the comma and `=` regressed. I updated the splitter to
retain whitespace compatibility while preserving commas in values, and added
focused coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
