bhollis-dbx commented on code in PR #58800:
URL: https://github.com/apache/spark/pull/58800#discussion_r4075562978


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/trees/TreeNodeSuite.scala:
##########
@@ -193,6 +264,58 @@ class TreeNodeSuite extends SparkFunSuite with SQLHelper {
     assert(transformed.origin.startPosition.isDefined)
   }
 
+  test("transform rules see node origins and restore the previous origin") {
+    val nodeOrigin = Origin(line = Some(1))
+    val previousOrigin = Origin(line = Some(2))
+    val expression = CurrentOrigin.withOrigin(nodeOrigin) {

Review Comment:
   Updated the test so the parent and children have distinct origins.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to