gaogaotiantian commented on PR #58892: URL: https://github.com/apache/spark/pull/58892#issuecomment-5805900320
Personally I think it would be very difficult to build a full map for all source files. There will be new files and it's not simple to maintain. I still believe that a "just run everything" fallback makes sense. However, if we can put files into the corresponding module, that's a nice thing. The major concern is still "whether we can build the dependency graph nicely". This is the foundation to "run tests smartly". I don't know at this point, because some of the dependencies are not super obvious. In general, I'm supporting the effort to make the test modules clearer and run less unnecessary tests. But I'd rather run redundant tests than miss important tests to run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
