cloud-fan commented on code in PR #58244:
URL: https://github.com/apache/spark/pull/58244#discussion_r4095579224
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/RowLevelOperationSuiteBase.scala:
##########
@@ -127,6 +127,15 @@ abstract class RowLevelOperationSuiteBase
catalog.createTable(ident, tableInfo)
}
+ /** Declares a session variable for the duration of `f`, dropping it
afterwards. */
Review Comment:
Confirmed: the custom helper is gone, and these tests now use the inherited
QueryTest helper with plain DECLARE, so nested same-name use cannot silently
clobber the outer variable. Thanks.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:3854074685","thread_id":"inline:3854074685","verdict_sha256":"a8fceb0919012a510abe3db7e37fd3ebccc899f8f749bb987780c688b63e7825"}
-->
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveReferencesInUpdate.scala:
##########
@@ -67,7 +67,8 @@ class ResolveReferencesInUpdate(val catalogManager:
CatalogManager)
val newUpdate = u.copy(
assignments = newAssignments,
- condition = u.condition.map(resolveExpressionByPlanChildren(_, u)))
+ condition = u.condition.map(
+ resolveExpressionByPlanChildren(_, u, includeLastResort = true)))
Review Comment:
Confirmed: the Scaladoc now separates assignment default handling from
condition-only outer-reference and SQL-variable fallback. Thanks.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:3854074693","thread_id":"inline:3854074693","verdict_sha256":"a8fceb0919012a510abe3db7e37fd3ebccc899f8f749bb987780c688b63e7825"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
