MaxGekk commented on PR #59069: URL: https://github.com/apache/spark/pull/59069#issuecomment-5845573296
@dongjoon-hyun @viirya @LuciferYang @cloud-fan @wangyum could you review this when you have a chance? It is the follow-up to SPARK-59783: `splitExpressionsWithCurrentInputs` now splits under whole-stage codegen when the caller passes the expressions the code was generated for, from which the split methods' arguments - the locals the code reads - are computed; `CaseWhen` passes them, so SPARK-33301's large CASE WHEN compiles inside a stage and its stage method stays under the JIT limit. The argument walk follows the subexpression-elimination states (@viirya, @LuciferYang) and `With`/`CommonExpressionRef` (@cloud-fan) the way `getLocalInputVariableValues` and `CommonExprSlots.methodArgs` do, and refuses where a local cannot be passed. CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
