dongjoon-hyun commented on PR #893: URL: https://github.com/apache/spark-kubernetes-operator/pull/893#issuecomment-5859702188
Thank you for the review, @peter-toth. Both comments are addressed in cf1ad0c8. - **Blocking 1**: Added the two assertions for the clause which stops the `evicted && suspend` branch from firing again. Both fail once the clause is removed. - **Non-blocking 2**: `keepKueueWorkload` is now called only for a cluster suspended by an eviction, so a resume from `spec.suspend` releases a leftover `Workload` whatever state Kueue left it in. The new `resumedClusterReleasesDeactivatedWorkload` pins it. In the previous CI run, the only failure was an unrelated flaky test, `LoggingUtilsTest.testSparkClusterLogContainsMDC` on Java 21, and the `kueue` E2E test passed, including the new preemption step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
