Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6825#discussion_r32661616
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -109,7 +109,7 @@ trait ExpressionEvalHelper {
}
val actual = plan(inputRow)
- val expectedRow = new
GenericRow(Array[Any](CatalystTypeConverters.convertToCatalyst(expected)))
+ val expectedRow =
InternalRow.fromSeq(Array(CatalystTypeConverters.convertToCatalyst(expected)))
if (actual.hashCode() != expectedRow.hashCode()) {
--- End diff --
If different types of rows have different hash code implementations they we
cannot use them as keys in a hash table. This is to check that they all share
an implementation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
