Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6827#discussion_r32663412
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -431,7 +435,9 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
* Replays the events in the specified log file and returns information
about the associated
* application.
*/
- private def replay(eventLog: FileStatus, bus: ReplayListenerBus):
FsApplicationAttemptInfo = {
+ private def replay(
+ eventLog: FileStatus,
+ bus: ReplayListenerBus): Option[FsApplicationAttemptInfo] = {
--- End diff --
need to update the javadoc to explain when we return `Some(...)` vs `None`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
