jubins commented on PR #59094: URL: https://github.com/apache/spark/pull/59094#issuecomment-5917761843
> The production fixes look correct. One test gap remains: the row-evaluated invalid-k case mixes a valid sketch with the NULL row, so the valid row can raise the expected error even if NULL rows bypass validation. Please make that assertion depend only on a non-foldable NULL state. thank you for reviewing @cloud-fan, added tests for both in recent commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
