gengliangwang commented on code in PR #58632:
URL: https://github.com/apache/spark/pull/58632#discussion_r4170057264
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AssignmentUtils.scala:
##########
@@ -57,13 +59,17 @@ object AssignmentUtils extends SQLConfHelper with
CastSupport {
* (preserving existing fields).
* @param coerceNestedTypes whether to coerce nested types to match the
target type
* for complex types
+ * @param ansiStoreAssignmentCastCheck when the ANSI store-assignment cast
check runs:
+ * ANALYSIS (default) rejects an unsafe
cast at analysis
+ * time; RUNTIME rejects invalid values
at execution time.
* @return aligned update assignments that match table attributes
*/
def alignUpdateAssignments(
attrs: Seq[Attribute],
assignments: Seq[Assignment],
fromStar: Boolean,
- coerceNestedTypes: Boolean): Seq[Assignment] = {
+ coerceNestedTypes: Boolean,
+ ansiStoreAssignmentCastCheck: AnsiStoreAssignmentCastCheck = ANALYSIS):
Seq[Assignment] = {
Review Comment:
nit: what if in the future SchemaAlignmentConfig.DEAULT is changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
