HyukjinKwon commented on code in PR #59089:
URL: https://github.com/apache/spark/pull/59089#discussion_r4174238936
##########
core/src/main/scala/org/apache/spark/SparkContext.scala:
##########
@@ -2719,6 +2733,14 @@ class SparkContext(config: SparkConf) extends Logging {
if (_statusStore != null) {
_statusStore.close()
}
+ if (_proxyBaseSetByContext) {
Review Comment:
**Nit (P3):** Only the restore branch of stop()'s proxyBase handling has a
regression signal. The clear branch -- taken when no non-app-specific prior
proxyBase was saved -- has no test asserting `spark.ui.proxyBase` is cleared
after a reverse-proxy context stops, so a change that left the derived value
stale on stop() would pass every test.
**Verification:**
- **Regression:** After stopping a reverse-proxy context started with no
non-app-specific prior proxyBase, assert the system property is cleared; the
test fails if stop() leaves the derived value set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
