viirya opened a new pull request, #43: URL: https://github.com/apache/spark-connect-gateway/pull/43
### What changes were proposed in this pull request? Move the six `opentelemetry*` crates from 0.32 to 0.33, and `tracing-opentelemetry` from 0.33 to 0.34: ``` opentelemetry 0.32 -> 0.33 opentelemetry_sdk 0.32 -> 0.33 opentelemetry-otlp 0.32 -> 0.33 opentelemetry-semantic-conventions 0.32 -> 0.33 opentelemetry-stdout 0.32 -> 0.33 opentelemetry-proto 0.32 -> 0.33 tracing-opentelemetry 0.33 -> 0.34 ``` `Cargo.toml` and `Cargo.lock` only — no source changes, as the APIs this repo uses are unchanged between 0.32 and 0.33. This supersedes #41, which is closed. ### Why are the changes needed? Routine dependency maintenance, but the shape is worth explaining since the title names two things and the diff moves eight crates. These crates share types across their public APIs, so raising one on its own leaves two majors of `opentelemetry` in the dependency graph and the traits stop lining up. `tracing-opentelemetry`'s version is offset by one minor — 0.34 is the release that tracks `opentelemetry` 0.33 — so the whole family moves together. This is the same shape as SPARK-59548, which took the group from 0.31 to 0.32. Worth noting that dependabot raised this *correctly*, as a single grouped PR under the grouping added in SPARK-59550, rather than as the seven individually unmergeable single-crate PRs it would have produced before. The grouping also behaved as intended at the edges: `tracing-opentelemetry` was included, while `tracing` and `tracing-subscriber` were left out — they carry no version coupling to OpenTelemetry, and sweeping them in would have held their updates behind this family for no reason. ### Does this PR introduce _any_ user-facing change? No. Dependency versions only; no change to configuration, metrics, span names, or any emitted telemetry. ### How was this patch tested? **The check that shows the version skew is actually gone** is the lockfile resolving a single `opentelemetry`. Building is not sufficient proof — a skewed graph still compiles until the mismatched trait is named, which is exactly how #8 looked before it failed: ``` $ grep -c '^name = "opentelemetry"$' Cargo.lock 1 ``` `opentelemetry` and `opentelemetry_sdk` resolve to 0.33.0, `tracing-opentelemetry` to 0.34.0, and `cargo metadata --locked` confirms the lock agrees with the manifest. **The tracing integration test matters more here than the unit tests**, and passes: ``` test tracing_emits_spans_and_propagates_traceparent ... ok ``` Feature unification in this dependency group has previously caused application spans to be dropped silently — enabling `opentelemetry`'s `spec_unstable_logs_enabled` through an unrelated path made the linked `tracing-opentelemetry` discard them — and neither a build nor the unit tests would catch that. This test asserts spans are emitted and `traceparent` is propagated, so it is the one that would notice. **The nine Redis integration tests** were run against a real Redis as well and are unaffected, as expected. **Full workspace:** | check | result | |---|---| | `cargo test --workspace` | 204 passed, 0 failed, 10 ignored — same as the baseline on `main` | | `cargo clippy --workspace --all-targets -- -D warnings` | clean | | `cargo fmt --all --check` | clean | I also confirmed this PR leaves the proto work from #40 and #42 untouched (`dev/sync-protos.sh` reports `identical: 11`), since a sibling dependabot PR had quietly reverted it and that is worth checking rather than assuming. ### Was this patch authored or co-authored using generative AI tooling? Yes, co-authored with Claude Code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
