viirya commented on PR #41: URL: https://github.com/apache/spark-connect-gateway/pull/41#issuecomment-5989649664
Superseded by #43 (SPARK-59973), which applies the same upgrade — the six `opentelemetry*` crates to 0.33 and `tracing-opentelemetry` to 0.34. Worth saying that this PR was raised *correctly*: the grouping added in SPARK-59550 did its job, so this arrived as one coherent group rather than the seven individually unmergeable single-crate PRs that preceded it (#8 being the example). The edges behaved too — `tracing-opentelemetry` was grouped in, while `tracing` and `tracing-subscriber` were correctly left out. Closing only because this branch was cut before the proto work on `main` (#40, #42) landed, so the diff as filed carries that older base. The upgrade itself checked out and is verified in #43: the lockfile resolves a single `opentelemetry`, `tracing_emits_spans_and_propagates_traceparent` passes, and the full workspace is 204 tests green. Thanks, dependabot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
