peter-toth commented on code in PR #55885:
URL: https://github.com/apache/spark/pull/55885#discussion_r4185889074
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/functions/ReducibleFunction.java:
##########
@@ -101,6 +155,6 @@ default Reducer<I, O> reducer(
* @return a reduction function if it is reducible, null if not.
*/
default Reducer<I, O> reducer(ReducibleFunction<?, ?> otherFunction) {
- throw new UnsupportedOperationException();
+ return reducer(new Literal<?>[0], otherFunction, new Literal<?>[0]);
Review Comment:
Thanks for flagging it. That's on me: I suggested the tag without checking
that the build doesn't register it. I'd rather not introduce a new Javadoc tag
for a single note, so please drop the build changes and keep it as a plain
paragraph instead:
```
* <p>
* This default delegates to
* {@link #reducer(Literal[], ReducibleFunction, Literal[])}, so an
implementation of that
* overload must not call back into this method.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
