dongjoon-hyun opened a new pull request, #936:
URL: https://github.com/apache/spark-kubernetes-operator/pull/936
### What changes were proposed in this pull request?
This PR aims to fix `docs/configuration.md` to document that the values in
the property file, `spark-operator.properties`, take precedence over the system
properties of the operator JVM.
### Why are the changes needed?
The doc says that system properties, e.g. `-D` options to the operator JVM,
override the values in the property file. However,
`SparkOperatorConfManager.initialize()` loads `System.getProperties()` first
and then the property file, so the property file wins for the same key.
```java
private void initialize() {
initialConfig.putAll(System.getProperties());
Properties properties =
getProperties(
System.getProperty(INITIAL_CONFIG_FILE_PATH_PROPS_KEY,
INITIAL_CONFIG_FILE_PATH));
initialConfig.putAll(properties);
```
This has been the behavior since SPARK-48786 and in all releases including
[1.0.0](https://github.com/apache/spark-kubernetes-operator/releases/tag/1.0.0)
(2026-07-23). This PR fixes the doc instead of the behavior. The Helm chart
renders runtime-resolved properties into the property file, e.g.
`spark.kubernetes.operator.health.probePort`, which must match the container
ports and probes of the operator pod. Keeping the property file authoritative
prevents `-D` options in `jvmArgs` from overriding them.
### Does this PR introduce _any_ user-facing change?
No behavior change. This fixes the documentation to match the existing
behavior.
### How was this patch tested?
Manually verified by running the operator jar with
`-Dspark.kubernetes.operator.basePropertyFileName=<file>`, where both the file
and a `-D` option set `spark.kubernetes.operator.reconciler.intervalSeconds`.
`SparkOperatorConf.RECONCILER_INTERVAL_SECONDS.getValue()` returned the value
in the file.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
