Yicong-Huang commented on code in PR #59246:
URL: https://github.com/apache/spark/pull/59246#discussion_r4192103878
##########
python/pyspark/worker.py:
##########
@@ -1808,6 +1875,7 @@ def read_udfs(pickleSer, udf_info_list, eval_type,
runner_conf, eval_conf):
for udf_index, udf_info in enumerate(udf_info_list)
]
handler = handler_cls(udfs=udfs, runner_conf=runner_conf,
eval_conf=eval_conf)
+ handler.set_worker_metrics(metrics)
Review Comment:
I kind of don't like metrics to be passed from outside and to be set:
`read_udfs` is supposed to be a reader/get method.
if we need the metrics to be on the handler, can't handlers just create them
directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
