vboo123 commented on PR #59258: URL: https://github.com/apache/spark/pull/59258#issuecomment-6029065318
I worked through the soundness of the transitive chaining and I think it holds — under Spark's total-order comparison (SQLOrderingUtil.compareDoubles, where NaN == NaN and NaN sorts highest) a NaN can't satisfy the small side of a <, and a NULL makes the original predicate UNKNOWN so the row is already dropped before the inferred bound matters. The one gap I notice: the new tests all assert plan shape (comparePlans / constraints.contains), so none would actually catch an unsound bound that drops a row. Would it be worth a row-level test — a float/double column including NaN, plus a widening-cast case like int < long < lit — to pin the correctness down? Or is that covered somewhere I missed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
