gaogaotiantian commented on PR #58860: URL: https://github.com/apache/spark/pull/58860#issuecomment-6044784991
I'm okay with the module itself, but it seems like you wrote a new function just to test that all the pyspark modules depend on the base module? Is the file even executed (as a doctest) in CI? If not, I don't think this function is valuable for us. I mean of course it's nice to have some tests to confirm these, but we may not need to do it immediately? Especially if the test can only be executed manually by running this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
