Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12808084
--- Diff: bin/compute-classpath.cmd ---
@@ -20,6 +20,13 @@ rem
rem This script computes Spark's classpath and prints it to stdout; it's
used by both the "run"
rem script and the ExecutorRunner in standalone cluster mode.
+rem If we're called from spark-class2.cmd, it already set
enabledelayedexpansion and setting
+rem it here would stop us from affecting its copy of the CLASSPATH
variable; otherwise we
+rem need to set it here because we use !datanucleus_jars! below.
+if "%DONT_PRINT_CLASSPATH%"=="1" goto skip_delayed_expansion
+setlocal enabledelayedexpansion
+:skip_delayed_expansion
+
--- End diff --
Also, if the person runs `spark-class` and then run `compute-classpath`
directly, it will skip delayed expansion when it shouldn't, because windows env
vars are global and persistent. Maybe we should do `set DONT_PRINT_CLASSPATH=`
here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
