Echoslayer opened a new pull request, #59366:
URL: https://github.com/apache/spark/pull/59366

   #### What changes were proposed in this pull request?
   
   Add five test methods for Python Spark Connect configuration responses and 
partitioning expressions:
   
   - `test_connect_conf.py`: configuration warnings, bulk value conversion and 
the `silent` flag, and invalid `isModifiable` responses.
   - `test_connect_plan.py`: bucket expressions with integer or Column counts, 
and function names and arguments for `years`, `months`, `days`, and `hours`.
   
   The configuration tests use a dedicated `test_connect_conf.py` module, 
registered with the Connect test runner, to group checks for `RuntimeConf`. The 
existing Connect `test_bucket` already checks string bucket counts, so no 
duplicate error test is added.
   
   JIRA: https://issues.apache.org/jira/browse/SPARK-60164
   
   #### Why are the changes needed?
   
   These tests catch dropped warnings, incorrect configuration value 
conversion, and acceptance of invalid boolean responses. They also catch 
incorrect function names or argument order in Protocol Buffers (protobuf) 
expressions, without requiring a Connect server.
   
   #### Does this PR introduce _any_ user-facing change?
   
   No.
   
   #### How was this patch tested?
   
   ```bash
   PATH="$PWD/.venv/bin:$PATH" OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES \
   python/run-tests \
     --python-executables="$PWD/.venv/bin/python" \
     --parallelism 1 \
     --testnames 
'pyspark.sql.tests.connect.test_connect_conf,pyspark.sql.tests.connect.test_connect_plan,pyspark.sql.tests.connect.test_parity_conf,pyspark.sql.tests.connect.test_parity_functions
 FunctionsParityTests.test_bucket'
   
   PATH="$PWD/.venv/bin:$PATH" dev/lint-python
   
   git diff --check
   ```
   
   - All 94 tests passed on Python 3.12.12, with no failures, errors, or skips: 
3 configuration unit tests, 86 plan tests, 4 configuration parity tests, and 
the existing Connect `test_bucket` case.
   - The five added tests also passed a separate focused run.
   - Full `dev/lint-python` and `git diff --check`: passed.
   
   Validation used the revised working tree. The first runner attempt was 
blocked by sandbox socket permissions; the rerun outside the sandbox passed. 
The full SQL suite was not run, and coverage was not remeasured.
   
   #### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: OpenAI Codex (GPT-6)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to