gaogaotiantian commented on code in PR #59368:
URL: https://github.com/apache/spark/pull/59368#discussion_r4240713694
##########
python/pyspark/sql/tests/pandas/helper/helper_pandas_transform_with_state.py:
##########
@@ -897,6 +897,13 @@ def init(self, handle: StatefulProcessorHandle) -> None:
def handleInputRows(self, key, rows, timerValues) ->
Iterator[pd.DataFrame]:
import datetime
+ # Clearing a populated list state removes both its existence and its
contents.
Review Comment:
This is not the correct way to add coverage. This class is a helper class,
not a test case. This helper class does some customer data handling, but you
should not just randomly add and clear the list state because you need some
extra coverage. You can do this in a test method. Or you need to figure out a
way to call `clear()` properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
