srielau commented on PR #59325: URL: https://github.com/apache/spark/pull/59325#issuecomment-6118096746
Thanks for the thorough re-review. Pushed `0e894f626aa` addressing all of it: - Fixed the key-check `NullPointerException` (guard the check on `FIELD_NAME`) with a regression test asserting a valid-width CHAR key matches the STRING-keyed baseline. - Reworded the stale XML comparisons (scaladoc + test comment) for the post-SPARK-60103 world. - Dropped the unused `assertDuplicateMapKey`/`assertDuplicateMapKeyError` helpers (merge leftover). - Corrected the two migration-guide sentences (and the PR description) on PERMISSIVE containment and persisted-view scans. - Added the two missing tests: PERMISSIVE array-of-map containment, and a catalog JSON table scan (off-width key nulled, duplicate name -> `DUPLICATED_MAP_KEY`). - Updated the FAILFAST example in the PR description to the current error message. On the merge conflict: it was already resolved earlier by merging master (`eaade2f`), keeping both the JSON helpers and your XML helpers, so `Run / Check changes` should pass now and the new tests will run in CI. One optional item left open (noted on the XML error-condition thread): aligning `UNSUPPORTED_XML_CHAR_VARCHAR_MAP_KEY`'s wording and key cap with the JSON condition, which I'd prefer to do as a small follow-up to keep this PR scoped to SPARK-60108. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
