viirya commented on PR #59332: URL: https://github.com/apache/spark/pull/59332#issuecomment-6129372259
@HyukjinKwon On the decision challenge in your review summary (a lost writer interrupt): I can't rule out an upstream iterator that catches the `InterruptedException` and carries on, so the wait now interrupts the writer again on every 10-second warning while the writer is still running. The interrupt is guarded so that a pool thread that has already left the writer is never interrupted. A writer blocked in `channel.write` then fails with `ClosedByInterruptException`, which also closes the worker channel. The new test "the writer is interrupted again if it consumed the interrupt" covers it, and it fails without the repeated interrupt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
