viirya commented on PR #59334: URL: https://github.com/apache/spark/pull/59334#issuecomment-6133279031
Thanks, @dongjoon-hyun. Addressed in e7dd3a4: - The helper now reads the legacy conf only for a zero with a negative scale and for a value with too many integral digits, as before this PR, so an in-range string doesn't touch the conf. I used your suggested structure, which also removes the duplicate branch. - The comment now says the precision doesn't grow with a positive exponent. I didn't cap the scale of zero: a nonzero value like `'1e-50'` gets precision 50 the same way, and `changePrecision` handles both. - The Javadoc now says exactly when `null` is returned. - `DecimalSuite` now also checks zero under the legacy conf (scale -39 is kept) and `'0.00'` through `fromStringANSI`. - I added the zero case and the `Literal` example to SPARK-60132. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
