bhollis-dbx commented on PR #59283: URL: https://github.com/apache/spark/pull/59283#issuecomment-6128951858
Addressed the six new findings in 049f52ef8: - Lower named-struct updates to a `CreateNamedStruct` containing only surviving values, removing discarded expressions and unused `With` definitions. - Restore the extraction guard so update chains merge before simplification introduces null checks. - Preserve legacy nested-update SQL rendering and generated column names without rebuilding expanded expression trees. - Replace positional List lookups with indexed access or iterators. - Restore single-pass (`Once`) lowering and correct the CSE test comments. Added regression coverage for discarded failing aggregates, projection-inlined updates, nested extraction, generated names, single-pass lowering, and 100/500-field interpreted and codegen results. Validation: 372 tests passed across 11 suites using freshly compiled sources against the cached SBT test classpath. Benchmarks were not rerun for this commit; previously reported results are unchanged measurements, not measurements of this revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
