gerashegalov commented on code in PR #59313:
URL: https://github.com/apache/spark/pull/59313#discussion_r4254661851
##########
python/pyspark/sql/session.py:
##########
@@ -2292,6 +2296,12 @@ def addArtifacts(
"condition": "True together",
},
)
+ # Native data source packages are artifacts of the session in the JVM,
whatever the
+ # flags, as with Spark Connect.
+ for p in path:
+ if p.endswith(".sparkpkg"):
+ self._jsparkSession.addArtifact(os.path.abspath(p))
Review Comment:
What if `p` is `file:///tmp/some.sparkpkg`? `abspath` will treat it as a
relative path yielding `$PWD/file:///tmp/some.sparkpkg`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
