surawut-jirasaktavee commented on PR #59422:
URL: https://github.com/apache/spark/pull/59422#issuecomment-6140310765
CI result: 29 jobs passed, 2 skipped, and 1 failed (`Build modules:
pyspark-connect-old-client`).
The failure is expected from the behavior change in this PR. That job runs
the `branch-4.0` PySpark tests against a server built from this PR, and the
`branch-4.0` doctest for `regexp_instr` (Example 2) still asserts the old
result, where `idx` was ignored:
```
Failed example:
df.select('*', sf.regexp_instr('str', sf.lit(r'\d+(a|b|m)'),
sf.lit(1))).show()
Expected: 1
Got: 2
```
`2` is the position of group 1 (`a`) in `1a 2b 14m`, which is the result
this PR is meant to produce. This PR updates the same doctest on master.
Should I open a separate PR against `branch-4.0` to update that doctest so
this job passes? Or is there a preferred way to handle expected behavior
changes in the old-client tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
