HyukjinKwon commented on code in PR #59293:
URL: https://github.com/apache/spark/pull/59293#discussion_r4263334451
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1782,6 +1782,10 @@ class Analyzer(
}
expanded
}
+ // If the pivot aggregate function argument contains Stars, expand it,
e.g. count(*) to
+ // count(1), as for Aggregate.
+ case p: Pivot if containsStar(p.aggregates) =>
Review Comment:
Thanks, verified at 36348bb. A bare top-level `*` in the pivot aggregates is
now rejected up front with `INVALID_USAGE_OF_STAR_OR_REGEX` naming `Pivot`, and
the new AnalysisSuite test covers the case where the grouping and pivot columns
are still unresolved.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"inline:4236318288","thread_id":"inline:4236318288","verdict_sha256":"b3a6c1563a9c7fe986d6de518249b500381abbbd92a4d0290fa1382ab53e3430"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
