DaemonforY opened a new pull request, #59436:
URL: https://github.com/apache/spark/pull/59436
### What changes were proposed in this pull request?
This PR fixes the description of `spark.history.ui.acls.enable` in
`docs/security.md` and in its config doc in `History.scala`. They say ACL
checks are performed regardless of what applications had set for
`spark.ui.acls.enable`; the setting that actually controls application ACLs is
`spark.acls.enable`.
### Why are the changes needed?
`spark.ui.acls.enable` is no longer read anywhere:
- `SecurityManager` only reads `spark.acls.enable`: `private var aclsOn =
sparkConf.get(ACLS_ENABLE)`, where `ACLS_ENABLE` is defined in `UI.scala`.
- The legacy key used to be honored as a fallback ("keep
spark.ui.acls.enable for backwards compatibility with 1.0"):
`sparkConf.getBoolean("spark.acls.enable",
sparkConf.getBoolean("spark.ui.acls.enable", false))`. That fallback was
removed in SPARK-26482 (commit d9e4cf67c06, first released in 3.0.0), and the
key is not registered as a deprecated or alternative config in `SparkConf`.
So a user following the current description may set `spark.ui.acls.enable`,
which has no effect.
### Does this PR introduce _any_ user-facing change?
No behavior change. Documentation only: the description of
`spark.history.ui.acls.enable` now refers to `spark.acls.enable`.
### How was this patch tested?
Documentation-only change; no tests are needed. Both modified lines are
within the 100-character limit.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
