HyukjinKwon commented on PR #59184:
URL: https://github.com/apache/spark/pull/59184#issuecomment-6158206593
Thanks for the update. The description now matches the code, and the
Scaladoc spells out the first-child contract. One follow-up on that Scaladoc,
which came from my earlier suggested wording: temporary functions get a
`ResolvedIdentifier` on `FakeSystemCatalog` straight from the parser, so "an
`UnresolvedIdentifier` before analysis" only holds for persistent functions. I
left an inline note with a suggested tweak.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6152076490","thread_id":"conversation:6152076490","verdict_sha256":"b6cc37ff61f17ec397d777c9e88c76112285e01c866bf63dbb3da0a0b8d8a1a1"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
