HyukjinKwon commented on code in PR #59446:
URL: https://github.com/apache/spark/pull/59446#discussion_r4267266957
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -442,6 +442,168 @@ class SparkConnectPlannerSuite extends SparkFunSuite with
SparkConnectPlanTest {
assert(res.nodeName == "Aggregate")
}
+ // Builds a typed Scala UDF expression whose payload cannot be deserialized,
optionally carrying
+ // a JVM origin whose head frame reports `fragment` as the API call site.
`numArgs` controls how
Review Comment:
**Nit (P3):** This wording mixes up two query-context fields. In
`DataFrameQueryContext`, the head frame's method name becomes `fragment` (the
API name, e.g. `groupByKey`), and `callSite` is built from the frames after it.
The tests below assert exactly that: `callSite()` is the second frame,
`example.AggregationJob.run(AggregationJob.scala:42)`. Calling the fragment the
"API call site" could mislead someone editing this fixture. Suggested wording:
"...optionally carrying a JVM origin whose head frame reports `fragment` as the
API method name and whose next frame becomes the call site."
**Verification:**
- **Inspection:** The comment text names `fragment` as the API method name
from the head frame and does not call it the call site, consistent with how
DataFrameQueryContext derives fragment and callSite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
