peter-toth commented on PR #59324: URL: https://github.com/apache/spark/pull/59324#issuecomment-6162821198
@dongjoon-hyun thank you for the review. [1410d4684cb](https://github.com/apache/spark/pull/59324/commits/1410d4684cb7dffceb36fb7ecce3c0168e67fda3) takes 1 to 3, 5 to 7 and 9 to 15, and I replied on 4, 8 and the second half of 7. I also went over every sentence the trim removed or rewrote, in all 13 files. That found two more claims the trim made false, both fixed in the same commit: - the struct case in `initializeLateMaterialization` also covered a struct the file does not have, which counts as missing by default too; - `giveUpOnError` said every fatal error is rethrown, while the decode catch absorbs a codec's `InternalError`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
