vranes commented on code in PR #59440: URL: https://github.com/apache/spark/pull/59440#discussion_r4268441801
########## docs/sql-ref-syntax-qry-select-asof-join.md: ########## @@ -28,10 +28,6 @@ right relation. The match is the closest row on the right that satisfies a requi `ASOF JOIN` is asymmetric: the left relation drives per-row lookups into the right, and reversing the operands changes the result. -`ASOF JOIN` is disabled by default. Set `spark.sql.join.asofJoin.enabled` to `true` Review Comment: I just thought we should remove this instruction while the feature is not completely ready yet, or even the whole doc ########## docs/sql-ref-syntax-qry-select-asof-join.md: ########## @@ -28,10 +28,6 @@ right relation. The match is the closest row on the right that satisfies a requi `ASOF JOIN` is asymmetric: the left relation drives per-row lookups into the right, and reversing the operands changes the result. -`ASOF JOIN` is disabled by default. Set `spark.sql.join.asofJoin.enabled` to `true` Review Comment: Reverted this change, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
