HyukjinKwon commented on PR #59410:
URL: https://github.com/apache/spark/pull/59410#issuecomment-6167382219
On testing against Iceberg: Spark's own test suites can't use the Iceberg
source, since Iceberg depends on Spark and not the other way round, so an
Iceberg-backed test would have to live in the Iceberg repo. The new assertion
compares `originalPartitionValues` with each split's raw `bucket(32, id)` key,
so it fails both without the fix and with a wrong-position projection. That
covers the invariant here, even though the in-memory rows don't throw the way
Iceberg's `StructInternalRow` does.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6163843135","thread_id":"conversation:6163843135","verdict_sha256":"bf93cb8e6e913fb9a2575b7fde0d018ba8a065c87f571228a14329863fb9dd62"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
