HyukjinKwon commented on PR #59424: URL: https://github.com/apache/spark/pull/59424#issuecomment-6166143391
@LuciferYang Thanks for checking the bindings against the header and the examples. On testing, good point: in e5352e191c14, the `Java 25 build with Maven` job of a pull request also runs `NativeDataSourceSuite`, `NativeDataSourceClusterSuite` and `NativeDataSourceConnectSuite` after the build, with the C++ compiler of the runner. On this commit, they ran on Linux with Java 25: 55 tests passed in `NativeDataSourceSuite` and `NativeDataSourceClusterSuite`, with only the Java version test canceled, as expected, and 2 in `NativeDataSourceConnectSuite`. So the FFM calls now run on every pull request. I also addressed the inline comment, with a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
