HyukjinKwon commented on PR #59305:
URL: https://github.com/apache/spark/pull/59305#issuecomment-6200451469
Thanks, verified. `DataTypeSuite` now decodes literal JSON with a bare
`"file"` in an array and a map, both standalone (unknown) and as the type of a
struct field (external). `StructField.dataTypeJsonValue` writes an external
file in a field as the plain `"file"` again, also inside arrays and maps, and a
field without collation metadata still skips `removeCollations`, so `MAP<STRING
COLLATE UTF8_BINARY, FILE EXTERNAL>` keeps its key collation. The JSON bullet
in the description now says the field type and metadata are written back as
they were read.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6198093748","thread_id":"conversation:6198093748","verdict_sha256":"06dfa0c0ed28a8fa17860627494c0e6effe76a8deebec8993f79491bdb079d75"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]