Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/6721#discussion_r32702082
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -51,16 +54,28 @@ abstract class LeafMathExpression(c: Double, name:
String)
* @param f The math function.
* @param name The short name of the function
*/
-abstract class UnaryMathExpression(f: Double => Double, name: String)
+abstract class AbstractUnaryMathExpression[T, U](name: String)
--- End diff --
Hmm, because `UnaryMathExpression` has `f: Double => Double` as parameter,
`BIN` can't directly extends it without modification. `BIN` has different input
type (`LONG`) and output type (`STRING`) compared with other expressions (input
and output: `DOUBLE`) based on `UnaryMathExpression`. For now, adding
`AbstractUnaryMathExpression` maybe the simplest approach to solve this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
